Rcfile cleanup#15775
Merged
dain merged 10 commits intotrinodb:masterfrom Feb 1, 2023
Merged
Conversation
dain
force-pushed
the
rcfile-cleanup
branch
2 times, most recently
from
09b04f1 to
455c530
Compare
electrum
approved these changes
Jan 23, 2023
findinpath
reviewed
Feb 1, 2023
Contributor
There was a problem hiding this comment.
typo in the commit message Imporve saftely
Slice RCFile compressed header buffer to exact size to avoid future bugs where a compression format attempts to over read the actual compressed data region.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename RCFile module and packages
Extract RCFile compression and utilities so they can be use by other formats
Simplify the compression interfaces to make reuse easier
(X) This is not user-visible or docs only and no release notes are required.